Re: [Xen-devel] [PATCH 2/3] xen/arm: do_trap_hypervisor: Separate hypervisor and guest traps

[Julien Grall <julien.grall@xxxxxxx>]

Hi Andrew,

On 04/05/17 19:03, Andrew Cooper wrote:
> On 04/05/17 18:54, Julien Grall wrote:
> > diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
> > index 6010c96c54..c8ce62ff96 100644
> > --- a/xen/arch/arm/traps.c
> > +++ b/xen/arch/arm/traps.c
> > @@ -2805,7 +2805,7 @@ static void enter_hypervisor_head(struct cpu_user_regs 
> > *regs)
> >      }
> >  }
> >
> > -asmlinkage void do_trap_hypervisor(struct cpu_user_regs *regs)
> > +asmlinkage void do_trap_guest_sync(struct cpu_user_regs *regs)
> >  {
> >      const union hsr hsr = { .bits = regs->hsr };
> >
> > @@ -2925,6 +2925,21 @@ asmlinkage void do_trap_hypervisor(struct cpu_user_regs 
> > *regs)
> >          do_trap_data_abort_guest(regs, hsr);
> >          break;
> >
> > +    default:
> > +        printk("Guest Trap. HSR=0x%x EC=0x%x IL=%x Syndrome=0x%"PRIx32"\n",
> Purely cosmetic, but I'd recommend "Unknown Guest Trap ..." or similar.
>
> Simply "Guest Trap" on its own doesn't covey any meaning to a user
> reading a console log as to whether is normal or exceptional to
> encounter this line.
Good point. I will update it.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel