Re: [Xen-devel] [PATCH 02/10 v2] xen/arm: vpl011: Add new vuart domctl interface to setup pfn and evtchn

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.04.17 at 21:23, <sstabellini@xxxxxxxxxx> wrote:
> On Fri, 28 Apr 2017, Bhupinder Thakur wrote:
>> --- a/xen/include/public/domctl.h
>> +++ b/xen/include/public/domctl.h
>> @@ -1138,6 +1138,15 @@ struct xen_domctl_psr_cat_op {
>>      uint32_t target;    /* IN */
>>      uint64_t data;      /* IN/OUT */
>>  };
>> +
>> +struct xen_domctl_vuart_op {
>> +#define XEN_DOMCTL_VUART_OP_SET_PFN      0
>> +#define XEN_DOMCTL_VUART_OP_GET_EVTCHN   1
>> +        uint32_t cmd;       /* XEN_DOMCTL_VUART_OP_* */
>> +        uint32_t pfn;       /* IN */
> 
> xen_pfn_t

And "pfn" is likely the wrong name: Do you mean an MFN or a GFN?

>> +        uint32_t evtchn;    /* OUT */
> 
> evtchn_port_t

Plus considering their fully separate use, the two should form a
union imo.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel