Re: [Xen-devel] [PATCH for-next v2 09/10] x86/domain: move PV specific code to pv/domain.c

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Apr 25, 2017 at 03:52:06PM +0100, Andrew Cooper wrote:
> > +    if ( is_pv_32bit_domain(d) )
> > +    {
> > +        if ( (rc = setup_compat_arg_xlat(v)) )
> > +            goto done;
> > +
> > +        if ( (rc = setup_compat_l4(v)) )
> > +            goto done;
> > +    }
> 
> Now the code is split apart like this, this construct looks suspicious. 
> I suppose it probably copes with the toolstack using
> XEN_DOMCTL_set_address_size and XEN_DOMCTL_max_vcpus in either order.

I don't know. We can't change this now because some toolstack may depend
on this particular behaviour.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel