Re: [Xen-devel] [PATCH v2 for-next v2 8/8] x86/mm: split HVM grant table code to hvm/mm.c

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Apr 19, 2017 at 09:35:50AM -0600, Jan Beulich wrote:
> >>> On 03.04.17 at 13:22, <wei.liu2@xxxxxxxxxx> wrote:
> > PG_external requires hardware support so the code guarded by that is HVM
> > only.
> > 
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > ---
> >  xen/arch/x86/hvm/Makefile         |  1 +
> >  xen/arch/x86/hvm/mm.c             | 85 
> > +++++++++++++++++++++++++++++++++++++++
> 
> I think the moved code would better go under x86/mm/, possibly (but
> not necessarily) into p2m.c.
> 

I disagree here. What good is there to keep this code when hvm support
is compiled out?

Wei.

> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel