Re: [Xen-devel] [PATCH 02/10] xen/arm: vpl011: Add new virtual console hvm params in Xen

[Bhupinder Thakur <bhupinder.thakur@xxxxxxxxxx>]

Hi Stefano,

On 19 April 2017 at 05:52, Stefano Stabellini <sstabellini@xxxxxxxxxx> wrote:
>>  long do_hvm_op(unsigned long op, XEN_GUEST_HANDLE_PARAM(void) arg)
>>  {
>> @@ -61,9 +137,45 @@ long do_hvm_op(unsigned long op, 
>> XEN_GUEST_HANDLE_PARAM(void) arg)
>>          if ( op == HVMOP_set_param )
>>          {
>>              d->arch.hvm_domain.params[a.index] = a.value;
>> +
>> +            if ( a.index == HVM_PARAM_VCONSOLE_PFN ||
>> +                 a.index == HVM_PARAM_VCONSOLE_EVTCHN )
>> +            {
>> +                             if ( vpl011_built() )
>
> Code style: we only use spaces for indentation in Xen. Please fix across
> the series.
>
I think this was introduced by mistake as I had to keep switching the
tab settings while modifying Xen code and xenconsoled code. I will fix
it.

> Also, I would move the "if ( vpl011_built() )" check to
> hvm_allow_set_param and hvm_allow_get_param.

I will move vpl011_built() inside the hvm_allow functions.

Regards,
Bhupinder

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel