Re: [Xen-devel] [PATCH for-4.9 v2] x86/vioapic: allow holes in the GSI range for PVH Dom0

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 18.04.17 at 11:14, <roger.pau@xxxxxxxxxx> wrote:
> @@ -554,6 +539,7 @@ void vioapic_reset(struct domain *d)
>          {
>              vioapic->base_address = mp_ioapics[i].mpc_apicaddr;
>              vioapic->id = mp_ioapics[i].mpc_apicid;
> +            vioapic->base_gsi = io_apic_gsi_base(i);

The value doesn't change over the lifetime of the vIO-APIC, so I'd
prefer this initialization to be done ...

> @@ -590,6 +576,8 @@ int vioapic_init(struct domain *d)
>      {
>          unsigned int nr_pins = is_hardware_domain(d) ? nr_ioapic_entries[i] :
>              ARRAY_SIZE(domain_vioapic(d, 0)->domU.redirtbl);
> +        unsigned int base_gsi = is_hardware_domain(d) ? io_apic_gsi_base(i)
> +                                                      : 0;

... somewhere below here, also avoiding to have the same logic
(Dom0 vs DomU) in two places. Perhaps the nr_pins calculation
could then be moved into that new if() (and its else) as well.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel