Re: [Xen-devel] [PATCH] tools:misc:xenpm: set max freq to all cpu with default cpuid

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Apr 13, 2017 at 10:41:06AM +0100, Julien Grall wrote:
> Hi Wei,
> 
> On 12/04/17 15:54, Wei Liu wrote:
> > On Wed, Apr 12, 2017 at 09:19:34AM +0800, Luwei Kang wrote:
> > > User can set max freq to specific cpu by
> > > "xenpm set-scaling-maxfreq <cpuid> <max freq>"
> > > or set max freq to all cpu with default cpuid by
> > > "xenpm set-scaling-maxfreq <max freq>".
> > > 
> > > Set max freq with defaule cpuid will cause
> > 
> > default
> > 
> > > segmentation fault after commit id d4906b5d05.
> > > This patch will fix this issue and add ability
> > > to set max freq with default cpuid.
> > > 
> > > Signed-off-by: Luwei Kang <luwei.kang@xxxxxxxxx>
> > 
> > I think this patch basically restores the code to the correct logic
> > before it was broken by d4906b5d05, so:
> > 
> > Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> 
> If I am not mistaken, this patch will re-introduce an error with clang
> build. From the commit message the sscanf was problematic:
> 
>     xenpm.c:102:23: error: data argument not used by format string
> [-Werror,-Wformat-extra-args]
>                     what, argv[argc > 1]);
>                           ^

That a different thing. The error was due to

        fprintf(stderr, argc ? "Invalid %s '%s'\n" : "Missing %s\n",
                what, argv[argc > 1]);

When argc was 0 the format string only contained one %s but two data
arguments were provided.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel