Re: [Xen-devel] [PATCH RFC 06/20] libxc/xc_sr: factor helpers out of handle_page_data()

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Mar 30, 2017 at 12:49:07AM -0400, Joshua Otto wrote:
> On Tue, Mar 28, 2017 at 08:52:26PM +0100, Andrew Cooper wrote:
> > On 27/03/17 10:06, Joshua Otto wrote:
> > > diff --git a/tools/libxc/xc_sr_stream_format.h 
> > > b/tools/libxc/xc_sr_stream_format.h
> > > index 3291b25..32400b2 100644
> > > --- a/tools/libxc/xc_sr_stream_format.h
> > > +++ b/tools/libxc/xc_sr_stream_format.h
> > > @@ -80,15 +80,15 @@ struct xc_sr_rhdr
> > >  #define REC_TYPE_OPTIONAL             0x80000000U
> > >  
> > >  /* PAGE_DATA */
> > > -struct xc_sr_rec_page_data_header
> > > +struct xc_sr_rec_pages_header
> > >  {
> > >      uint32_t count;
> > >      uint32_t _res1;
> > >      uint64_t pfn[0];
> > >  };
> > >  
> > > -#define PAGE_DATA_PFN_MASK  0x000fffffffffffffULL
> > > -#define PAGE_DATA_TYPE_MASK 0xf000000000000000ULL
> > > +#define REC_PFINFO_PFN_MASK  0x000fffffffffffffULL
> > > +#define REC_PFINFO_TYPE_MASK 0xf000000000000000ULL
> > >  
> > >  /* X86_PV_INFO */
> > >  struct xc_sr_rec_x86_pv_info
> > 
> > What are the purposes of these name changes?
> 
> I should definitely have explained this more explicitly, sorry about that.  I
> use the same exact structure (a count followed by a list of encoded 
> pfns+types)
> for three additional record types (POSTCOPY_PFNS, POSTCOPY_PAGE_DATA, and
> POSTCOPY_FAULT) later in the series when postcopy is introduced.  To enable 
> the
> generation and validation logic to be shared between all of the code that
> processes this sort of record, I renamed the structure and its associated 
> masks
> to be more generic.

This should be part of the commit message.

Wei.

> 
> Josh

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel