|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 0/5] Towards a restartable oxenstored
> On 7. Apr 2017, at 14:27, Jonathan Davies <Jonathan.Davies@xxxxxxxxxx> wrote: > > tools/ocaml/xenstored/domain.ml | 4 ++-- > tools/ocaml/xenstored/store.ml | 8 +++++++- > tools/ocaml/xenstored/xenstored.ml | 10 ++++++---- The OCaml code is looking good and I’d be happy to take it as it is. I noticed that the (existing) code for handling the path for the database file uses (^) to construct it. It would be better to use Filename.concat and this could have been done as part of this patch. Admittedly, this would be mostly cosmetic as it would help mainly portability to Windows. — Christian _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
 |
Lists.xenproject.org is hosted with RackSpace, monitoring our |