Re: [Xen-devel] [PATCH for-4.9] xsm: fix clang 3.5 build after c47d1d

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 04/07/2017 03:54 PM, Jan Beulich wrote:
>>>> On 07.04.17 at 16:34, <roger.pau@xxxxxxxxxx> wrote:
>> The changes introduced on c47d1d broke the clang build due to undefined
>> references to __xsm_action_mismatch_detected, because clang hasn't optimized
>> the code properly.
> 
> This starts to become annoying.

This is also breaking ARM32 build with GCC (4.9 and 5.4) (see [1]):

ld    -EL  -T xen.lds -N prelink.o \
    /home/osstest/build.107275.build-armhf-xsm/xen/xen/common/symbols-dummy.o 
-o /home/osstest/build.107275.build-armhf-xsm/xen/xen/.xen-syms.0
prelink.o: In function `xsm_default_action':
/home/osstest/build.107275.build-armhf-xsm/xen/xen/include/xsm/dummy.h:80: 
undefined reference to `__xsm_action_mismatch_detected'
gcc  -DPIC -marm -DBUILD_ID -fno-strict-aliasing -std=gnu99 -Wall 
-Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable 
-Wno-unused-local-typedefs   -g3 -O0 -fno-omit-frame-pointer 
-D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__ -MMD -MF 
.xc_dom_boot.opic.d -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE 
-D_LARGEFILE64_SOURCE -D_GNU_SOURCE  -I../../xen/common/libelf -Werror 
-Wmissing-prototypes -I. -I./include 
-I/home/osstest/build.107275.build-armhf-xsm/xen/tools/libxc/../../tools/include
 -D__XEN_TOOLS__ -pthread 
-I/home/osstest/build.107275.build-armhf-xsm/xen/tools/libxc/../../tools/libs/toollog/include
 
-I/home/osstest/build.107275.build-armhf-xsm/xen/tools/libxc/../../tools/include
 
-I/home/osstest/build.107275.build-armhf-xsm/xen/tools/libxc/../../tools/libs/evtchn/include
 
-I/home/osstest/build.107275.build-armhf-xsm/xen/tools/libxc/../../tools/include
 
-I/home/osstest/build.107275.build-armhf-xsm/xen/tools/libxc/../../tools/libs/devicemodel/include
 
-I/home/osstest/build.107275.build-armhf-xsm/xen/tools/libxc/../../tools/include
 -include 
/home/osstest/build.107275.build-armhf-xsm/xen/tools/libxc/../../tools/config.h 
-I/home/osstest/build.107275.build-armhf-xsm/xen/tools/libxc/../../tools/libs/call/include
 
-I/home/osstest/build.107275.build-armhf-xsm/xen/tools/libxc/../../tools/include
 
-I/home/osstest/build.107275.build-armhf-xsm/xen/tools/libxc/../../tools/libs/foreignmemory/include
 
-I/home/osstest/build.107275.build-armhf-xsm/xen/tools/libxc/../../tools/include
  -fPIC -c -o xc_dom_boot.opic xc_dom_boot.c 
ld: /home/osstest/build.107275.build-armhf-xsm/xen/xen/.xen-syms.0: hidden 
symbol `__xsm_action_mismatch_detected' isn't defined
ld: final link failed: Bad value
make[3]: *** [/home/osstest/build.107275.build-armhf-xsm/xen/xen/xen-syms] 
Error 1
Makefile:96: recipe for target 
'/home/osstest/build.107275.build-armhf-xsm/xen/xen/xen-syms' failed
make[3]: Leaving directory 
'/home/osstest/build.107275.build-armhf-xsm/xen/xen/arch/arm'
make[2]: *** [/home/osstest/build.107275.build-armhf-xsm/xen/xen/xen] Error 2
Makefile:136: recipe for target 
'/home/osstest/build.107275.build-armhf-xsm/xen/xen/xen' failed
make[2]: Leaving directory '/home/osstest/build.107275.build-armhf-xsm/xen/xen'
Makefile:45: recipe for target 'install' failed
make[1]: Leaving directory '/home/osstest/build.107275.build-armhf-xsm/xen/xen'
Makefile:97: recipe for target 'install-xen' failed
make[1]: *** [install] Error 2
make: *** [install-xen] Error 2
make: *** Waiting for unfinished jobs....

[1] 
http://logs.test-lab.xenproject.org/osstest/logs/107275/build-armhf-xsm/5.ts-xen-build.log

-- 
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel