Re: [Xen-devel] [PATCH v12 5/6] x86/ioreq server: Asynchronously reset outstanding p2m_ioreq_server entries.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.04.17 at 14:17, <yu.c.zhang@xxxxxxxxxxxxxxx> wrote:
> On 4/7/2017 7:28 PM, Jan Beulich wrote:
>>>>> On 07.04.17 at 12:50, <yu.c.zhang@xxxxxxxxxxxxxxx> wrote:
>>> @@ -546,12 +546,16 @@ static int resolve_misconfig(struct p2m_domain *p2m, 
>>> unsigned long gfn)
>>>                        {
>>>                             if ( e.sa_p2mt == p2m_ioreq_server )
>>>                             {
>>> -                             ASSERT(p2m->ioreq.entry_count > 0);
>>> -                             p2m->ioreq.entry_count--;
>>> +                             if ( p2m->ioreq.server == NULL )
>>> +                             {
>>> +                                 ASSERT(p2m->ioreq.entry_count > 0);
>>> +                                 p2m->ioreq.entry_count--;
>>> +                                 e.sa_p2mt = p2m_ram_rw;
>>> +                             }
>>>                             }
>>> -
>>> -                         e.sa_p2mt = p2m_is_logdirty_range(p2m, gfn + i, 
>>> gfn + i)
>>> -                                     ? p2m_ram_logdirty : p2m_ram_rw;
>>> +                         else
>>> +                             e.sa_p2mt = p2m_is_logdirty_range(p2m, gfn + 
>>> i, gfn + i)
>>> +                                         ? p2m_ram_logdirty : p2m_ram_rw;
>> Now you _never_ change away from ioreq-server, you only adjust
>> the counter.
> 
> Oh right.

Oh, wrong (i.e. I was wrong), you do change the type, and did
overlook that extra new line. So your first suggestion (still visible
above) seems right to me now.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel