Re: [Xen-devel] [PATCH v5] boot allocator: Use arch helper for virt_to_mfn on DIRECTMAP_VIRT region

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.04.17 at 01:10, <julien.grall@xxxxxxx> wrote:
> On 04/06/2017 11:13 AM, vijay.kilari@xxxxxxxxx wrote:
>> --- a/xen/common/page_alloc.c
>> +++ b/xen/common/page_alloc.c
>> @@ -520,9 +520,6 @@ static unsigned long init_node_heap(int node, unsigned 
>> long mfn,
>>      unsigned long needed = (sizeof(**_heap) +
>>                              sizeof(**avail) * NR_ZONES +
>>                              PAGE_SIZE - 1) >> PAGE_SHIFT;
>> -#ifdef DIRECTMAP_VIRT_END
>> -    unsigned long eva = min(DIRECTMAP_VIRT_END, HYPERVISOR_VIRT_END);
>> -#endif
>>      int i, j;
>>
>>      if ( !first_node_initialised )
>> @@ -532,9 +529,8 @@ static unsigned long init_node_heap(int node, unsigned 
> long mfn,
>>          first_node_initialised = 1;
>>          needed = 0;
>>      }
>> -#ifdef DIRECTMAP_VIRT_END
> 
> This is common code change and new in this version. As you keep Jan 
> Beulich's (x86 and common code maintainer) reviewed-by I would like to 
> confirm he is happy with that.

Well, the change is benign for x86, and looks correct for ARM (which
you support by giving your R-b). I'll commit this then.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel