Re: [Xen-devel] [PATCH v5 15/30] ARM: vGICv3: handle virtual LPI pending and property tables

[Andre Przywara <andre.przywara@xxxxxxx>]

Hi,

On 06/04/17 12:24, Julien Grall wrote:
> Hi Andre,
> 
> On 06/04/17 12:25, Andre Przywara wrote:
>> On 06/04/17 00:55, Stefano Stabellini wrote:
>>> On Thu, 6 Apr 2017, Andre Przywara wrote:
>>>> diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c
>>>> index cd9a2a5..9b0dc3d 100644
>>>> --- a/xen/arch/arm/vgic.c
>>>> +++ b/xen/arch/arm/vgic.c
>>>> @@ -20,6 +20,7 @@
>>>>  #include <xen/bitops.h>
>>>>  #include <xen/lib.h>
>>>>  #include <xen/init.h>
>>>> +#include <xen/domain_page.h>
>>>>  #include <xen/softirq.h>
>>>>  #include <xen/irq.h>
>>>>  #include <xen/sched.h>
>>>> @@ -589,6 +590,44 @@ void vgic_free_virq(struct domain *d, unsigned
>>>> int virq)
>>>>      clear_bit(virq, d->arch.vgic.allocated_irqs);
>>>>  }
>>>>
>>>> +int vgic_access_guest_memory(struct domain *d, paddr_t gpa, void
>>>> *addr,
>>>> +                             uint32_t size, bool_t is_write)
>>>
>>> Because there are no callers of this function, I think it breaks the
>>> build.
>>
>> How so? This is a non-static function in a .c file.
>> But indeed this function is prematurely introduced, we only need it two
>> patches later.
>> Fixed that.
> 
> I would actually prefer a separate patch for that and you likely need to
> add the Signed-off-by from Vijay as he was the author of the code.

Had just the same idea....

Cheers,
Andre.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel