Re: [Xen-devel] [PATCH v2 for-4.9 5/6] x86/emul: Drop swint_emulate infrastructure

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 06/04/17 08:30, Jan Beulich wrote:
>>>> On 05.04.17 at 19:33, <andrew.cooper3@xxxxxxxxxx> wrote:
>> With the SVM injection logic capable of doing its own emulation, there is no
>> need for this hardware-specific assistance in the common emulator.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> Reviewed-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
>> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
>> ---
>> CC: Tim Deegan <tim@xxxxxxx>
>> CC: Julien Grall <julien.grall@xxxxxxx>
>>
>> v2:
>>  * imm8 -> imm1
> This went wrong:
>
>>      case 0xce: /* into */
>>          if ( !(_regs.eflags & X86_EFLAGS_OF) )
>>              break;
>> -        src.val = EXC_OF;
>> -        swint_type = x86_swint_into;
>> -        goto swint;
>> +        /* Fallthrough */
>> +    case 0xcc: /* int3 */
>> +    case 0xcd: /* int imm1 */
> This needs to remain imm8.
>
>> +    case 0xf1: /* int1 (icebp) */
>> +        ASSERT(!ctxt->event_pending);
>> +        switch ( ctxt->opcode )
>> +        {
>> +        case 0xcc: /* int3 */
>> +            ctxt->event.vector = EXC_BP;
>> +            ctxt->event.type = X86_EVENTTYPE_SW_EXCEPTION;
>> +            break;
>> +        case 0xcd: /* int imm1 */
> As does this one.
>
>> +            ctxt->event.vector = src.val;
> This is what I would prefer to become imm1.

Ah - I see what you mean now.  Fixed.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel