Re: [Xen-devel] [PATCH v2 for-4.9 4/6] x86/svm: Introduce svm_emul_swint_injection()

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 04/05/2017 01:33 PM, Andrew Cooper wrote:
> Software events require emulation in some cases on AMD hardware.  Introduce
> svm_emul_swint_injection() to perform this emulation if necessary in
> svm_inject_event(), which will cope with any sources of event, rather than
> just those coming from x86_emulate().
>
> This logic mirrors inject_swint() in the x86 instruction emulator.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>


> +    /*
> +     * Read all 8/16 bytes so the idtr limit check is applied properly to
> +     * this entry, even though we don't look all the words read.
> +     */

("don't look *at* all the words read"? )

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel