Re: [Xen-devel] [PATCH V2] libxc: fix xc_translate_foreign_address()

[Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>]

On 04/05/2017 06:56 PM, Wei Liu wrote:
> On Wed, Apr 05, 2017 at 06:53:33PM +0300, Razvan Cojocaru wrote:
>> On 04/05/2017 06:03 PM, Wei Liu wrote:
>>> On Wed, Apr 05, 2017 at 03:58:05PM +0100, Julien Grall wrote:
>>>> Hi Razvan,
>>>>
>>>> On 05/04/17 15:53, Razvan Cojocaru wrote:
>>>>> Currently xc_translate_foreign_address() only checks for the PSE bit on
>>>>> level 2 entries (that's 2 MB pages on x64 and 32-bit with PAE, and 4 MB
>>>>> pages on 32-bit). But the Linux kernel sometimes uses 1 GB pages. This
>>>>> patch fixes that, by checking the PSE bit on level 3 entries if the guest
>>>>> has 4 translation levels (that means 64-bit guests only).
>>>>>
>>>>> Signed-off-by: Cristian-Bogdan Sirb <csirb@xxxxxxxxxxxxxxx>
>>>>
>>>> He is the author of the patch, correct? If so, he should be the author as
>>>> well (e.g From: ...).
>>>>
>>>> Also, you may want to add your signed-off-by here.
>>>>
>>>
>>> Julien, if you agree to let this patch go in 4.9. I can fix those up.
>>>
>>> Razvan, please tell me what you want me to do.
>>>
>>> Code-wise:
>>>
>>> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
>>
>> Whatever you'd like is fine with me. I don't care about my Signed-off-by
>> either way, but if the header comment header I've added justifies it
>> then please feel free to add:
>>
>> Signed-off-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
>>
> 
> Yes.
> 
>> in which case I suppose you won't need to also modify the From:.
>>
> 
> Who should be the author of this patch? I can't make a decision on your
> behalf...

Sorry, the author should definitely be Cristian-Bogdan Sirb
<csirb@xxxxxxxxxxxxxxx>. He discovered and fixed the issue, I merely
added the header comment.


Thanks,
Razvan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel