Re: [Xen-devel] [PATCH V2] libxc: fix xc_translate_foreign_address()

[Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>]

Hello Julien,

> On 05/04/17 15:53, Razvan Cojocaru wrote:
>> Currently xc_translate_foreign_address() only checks for the PSE bit on
>> level 2 entries (that's 2 MB pages on x64 and 32-bit with PAE, and 4 MB
>> pages on 32-bit). But the Linux kernel sometimes uses 1 GB pages. This
>> patch fixes that, by checking the PSE bit on level 3 entries if the guest
>> has 4 translation levels (that means 64-bit guests only).
>>
>> Signed-off-by: Cristian-Bogdan Sirb <csirb@xxxxxxxxxxxxxxx>
> 
> He is the author of the patch, correct? If so, he should be the author
> as well (e.g From: ...).
> 
> Also, you may want to add your signed-off-by here.

Alright, I can add my Signed-off for the comment (though it's not much
work, hence my initial reluctance :) ) in which case I suppose it's
alright to resend V3 from my address.


Thanks,
Razvan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel