Re: [Xen-devel] [PATCH] tools/xenstore: Add -Wno-bool-operation

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 05/04/17 14:27, Ian Jackson wrote:
> Andrew Cooper writes ("Re: [Xen-devel] [PATCH] tools/xenstore: Add 
> -Wno-bool-operation"):
>> I'm fairly sure this will break the Clang build.
> This seems unlikely.

Have you tried?

> I assume that clang has the same behaviour as gcc, for -Wno-unknown-warning.

Have you tried?

And independently of that,

andrewcoop@andrewcoop:/local/xen.git/xen$ git grep unknown-warning -- :/
andrewcoop@andrewcoop:/local/xen.git/xen$

>
>> Furthermore, the proper fix here is to make less "clever" code.  IMO,
>> this compiler warning is entirely legitimate, because relying on the
>> saturation behaviour of incrementing a boolean is worthy only for
>> obfuscated code.
> I don't care to argue about this.  Feel free to submit an alternative
> patch.

You have already identified the correct fix, which both makes the code
clearer to read, and compiles properly.  What is wrong with that?

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel