Re: [Xen-devel] [PATCH v2 for-next v2 1/8] mm: provide more grep fodders

[George Dunlap <george.dunlap@xxxxxxxxxx>]

On 03/04/17 12:22, Wei Liu wrote:
> Define several _* and *_x macros for better grep-ability. This also
> helps indexing tool like GNU Global.
> 
> No functional change.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>

"fodder" is uncountable, so the patch title should be "provide more grep
fodder".

With that fixed:

Acked-by: George Dunlap <george.dunlap@xxxxxxxxxx>

> ---
>  xen/include/xen/mm.h | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h
> index 88de3c1fa6..c92cba41a0 100644
> --- a/xen/include/xen/mm.h
> +++ b/xen/include/xen/mm.h
> @@ -60,7 +60,11 @@ TYPE_SAFE(unsigned long, mfn);
>  
>  #ifndef mfn_t
>  #define mfn_t /* Grep fodder: mfn_t, _mfn() and mfn_x() are defined above */
> +#define _mfn
> +#define mfn_x
>  #undef mfn_t
> +#undef _mfn
> +#undef mfn_x
>  #endif
>  
>  static inline mfn_t mfn_add(mfn_t mfn, unsigned long i)
> @@ -89,7 +93,11 @@ TYPE_SAFE(unsigned long, gfn);
>  
>  #ifndef gfn_t
>  #define gfn_t /* Grep fodder: gfn_t, _gfn() and gfn_x() are defined above */
> +#define _gfn
> +#define gfn_x
>  #undef gfn_t
> +#undef _gfn
> +#undef gfn_x
>  #endif
>  
>  static inline gfn_t gfn_add(gfn_t gfn, unsigned long i)
> @@ -118,7 +126,11 @@ TYPE_SAFE(unsigned long, pfn);
>  
>  #ifndef pfn_t
>  #define pfn_t /* Grep fodder: pfn_t, _pfn() and pfn_x() are defined above */
> +#define _pfn
> +#define pfn_x
>  #undef pfn_t
> +#undef _pfn
> +#undef pfn_x
>  #endif
>  
>  struct page_info;
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel