Re: [Xen-devel] [PATCH v3 5/8] x86/vioapic: allow the vIO APIC to have a variable number of pins

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.03.17 at 16:47, <roger.pau@xxxxxxxxxx> wrote:
> Although it's still always set to VIOAPIC_NUM_PINS (48).
> 
> Add a new field to the hvm_ioapic struct to contain the number of pins (number
> of IO redirection table entries) and turn the redirection table into a 
> variable
> sized array.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
with one remark:

> --- a/xen/include/asm-x86/hvm/vioapic.h
> +++ b/xen/include/asm-x86/hvm/vioapic.h
> @@ -49,12 +49,14 @@
>  
>  struct hvm_vioapic {
>      struct domain *domain;
> +    uint32_t nr_pins;
>      union {
> -        XEN_HVM_VIOAPIC(, VIOAPIC_NUM_PINS);
> +        XEN_HVM_VIOAPIC(, 0);

I think the 0 here isn't needed either, and having two blank macro
arguments doesn't seem any worse than having one. That way we
would have one less place where we depend on gcc's zero-length
array extension.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel