Re: [Xen-devel] [PATCH v3 3/4] xenstore: rework of transaction handling

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Mar 30, 2017 at 02:36:15PM +0200, Juergen Gross wrote:
> On 30/03/17 13:17, Wei Liu wrote:
> > On Tue, Mar 28, 2017 at 06:26:14PM +0200, Juergen Gross wrote:
> > [...]
> >> +
> >> +static char *transaction_get_node_name(void *ctx, struct transaction 
> >> *trans,
> >> +                                 const char *name)
> >> +{
> >> +  return talloc_asprintf(ctx, "%"PRIu64"/%s", trans->generation, name);
> >> +}
> >> +
> >> +/*
> >> + * Prepend the transaction to name if appropriate.
> >> + * In a transaction the transaction will be prepended for:
> >> + * - write accesses
> >> + * - read accesses of a node which has been written already in
> >> + *   the same transaction
> >> + */
> >> +int transaction_prepend(struct connection *conn, const char *name,
> >> +                  enum node_access_type type, TDB_DATA *key)
> > 
> > In the code this function is only ever called with type==READ, so either
> > you miss one callsite for write access or the comment is wrong.
> > 
> > I would like to hear from you before continuing.
> 
> This is a artefact of an earlier version. Now the write and delete
> case are handled directly in access_node(). I will remove the access
> type in V4.
> 

Please send an updated version. Sending just this one is OK.

> 
> Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel