Re: [Xen-devel] [PATCH v9 07/25] x86: refactor psr: L3 CAT: implement get hw info flow.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 27.03.17 at 15:19, <yi.y.sun@xxxxxxxxxxxxxxx> wrote:
> On 17-03-27 06:51:07, Jan Beulich wrote:
>> >>> On 27.03.17 at 14:24, <yi.y.sun@xxxxxxxxxxxxxxx> wrote:
>> > Please check above comments. Maybe below definitions are better?
>> > PSR_INFO_IDX_CAT_CBM_LEN
>> > PSR_INFO_IDX_COS_MAX
>> > PSR_INFO_IDX_CAT_FLAG
>> > PSR_INFO_ARRAY_SIZE
>> 
>> But why would the array size be 3 for some feature only having
>> COS_MAX (for example)? I think you should
>> - put common indexes first
>> - have PSR_INFO_CAT_ARRAY_SIZE (or PSR_INFO_NUM_IDX_CAT
>> or whatever, but with CAT in it).
>> 
> Per current known features, all of them (CAT/MBA) have three members in
> HW info. So, I think we can define ARRAY_SIZE to 3 and define its name to
> a common name so far.

Okay then.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel