Re: [Xen-devel] [PATCH v2 2/6] x86/viridian: don't put Xen version information in CPUID leaf 2

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: 21 March 2017 15:29
> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
> Cc: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>; xen-
> devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 2/6] x86/viridian: don't put Xen version information in
> CPUID leaf 2
> 
> >>> On 20.03.17 at 18:08, <paul.durrant@xxxxxxxxxx> wrote:
> > --- a/xen/arch/x86/hvm/viridian.c
> > +++ b/xen/arch/x86/hvm/viridian.c
> > @@ -106,6 +106,21 @@ typedef struct {
> >  #define CPUID6A_MSR_BITMAPS     (1 << 1)
> >  #define CPUID6A_NESTED_PAGING   (1 << 3)
> >
> > +/*
> > + * Version and build number reported by CPUID leaf 2
> > + *
> > + * These numbers are chosen to match the version numbers reported by
> > + * Windows Server 2008.
> > + */
> > +static uint16_t __read_mostly viridian_major_version = 6;
> > +integer_param("viridian_major_version", viridian_major_version);
> > +
> > +static uint16_t __read_mostly viridian_minor_version = 0;
> > +integer_param("viridian_minor_version", viridian_minor_version);
> > +
> > +static uint32_t __read_mostly viridian_build_number = 0x1772;
> > +integer_param("viridian_build_number", viridian_build_number);
> 
> While I realize it's easier for you this way, I dislike having three
> options here. How about
> 
> viridian-version=[<major>],[<minor>],[<build>]
> 

Ok. I guess I'll have to put back the initcall to parse this though.

  Paul

> ?
> 
> Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel