Re: [Xen-devel] [PATCH 04/11] Introduce cirros-separate-kernel-pv test

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Sun, 19 Mar 2017, Géza Gémes wrote:
> This test is the cirros equivalent of the bussybox-pv test
> 
> Signed-off-by: Géza Gémes <geza.gemes@xxxxxxxxx>
> ---
>  tests/cirros-separate-kernel-pv | 28 ++++++++++++++++++++++++++++
>  tests/series                    |  1 +
>  2 files changed, 29 insertions(+)
>  create mode 100644 tests/cirros-separate-kernel-pv
> 
> diff --git a/tests/cirros-separate-kernel-pv b/tests/cirros-separate-kernel-pv
> new file mode 100644
> index 0000000..bbbcf7d
> --- /dev/null
> +++ b/tests/cirros-separate-kernel-pv
> @@ -0,0 +1,28 @@
> +#!/usr/bin/env bash
> +
> +set -e
> +
> +function cirros-separate-kernel-pv-cleanup() {
> +    tear_down_cirros_tests $tmpdir
> +}
> +
> +function cirros-separate-kernel-pv-test() {
> +    if [[ ! -d $tmpdir ]]
> +    then
> +        set_up_cirros_tests

As I wrote in reply to the other patch, I would remove tmpdir and create
one from scratch for each test (but download the cirros images only
once).

Also, we need a pv specific init function here.

The rest looks good, thanks!


> +    fi
> +    cd $tmpdir
> +    cat >cirros-separate-kernel-pv.cfg <<EOF
> +name = "raisin-test"
> +memory = 128
> +vcpus = 2
> +kernel = "${tmpdir}/${CIRROS_KERNEL_FILE}"
> +ramdisk = "${tmpdir}/${CIRROS_INITRD_FILE}"
> +disk = [ '${tmpdir}/${CIRROS_ROOTFS_FILE},raw,xvda,rw' ]
> +extra = "root=/dev/xvda"
> +vif = [ 'bridge=xenbr1' ]
> +EOF
> +
> +    $SUDO xl create cirros-separate-kernel-pv.cfg
> +    check_guest_alive
> +}
> diff --git a/tests/series b/tests/series
> index a2f4b34..38ee35a 100644
> --- a/tests/series
> +++ b/tests/series
> @@ -1,3 +1,4 @@
>  busybox-pv
>  busybox-hvm
>  busybox-hvm-migrate
> +cirros-separate-kernel-pv
> -- 
> 2.7.4
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel