[Xen-devel] [OSSTEST PATCH] cs-adjust-flight: Remove broken memoisation of queries in for_things

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

The memo keys failed to include many of the important inputs.

CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
---
 cs-adjust-flight | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/cs-adjust-flight b/cs-adjust-flight
index 45c1420..85ced59 100755
--- a/cs-adjust-flight
+++ b/cs-adjust-flight
@@ -132,10 +132,9 @@ sub for_things ($$$$$$$) {
     my ($spec, $fn, $ifnone,
         $table, $keycol, $basecond, $basecondvals) = @_;
 
-    our (%thing_q, %things_q);
-    my $thing_q = $thing_q{$table} ||= $dbh_tests->prepare
+    my $thing_q = $dbh_tests->prepare
         ("SELECT * FROM $table WHERE $basecond AND $keycol = ?");
-    my $things_q = $things_q{$table} ||= $dbh_tests->prepare
+    my $things_q = $dbh_tests->prepare
         ("SELECT * FROM $table WHERE $basecond");
 
     my ($specfn,$exact) = notspec_exfn("FOR_THINGS $table.$keycol",$spec);
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel