Re: [Xen-devel] [PATCH] x86emul: correct DECLARE_ALIGNED()

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 16/03/17 13:31, Jan Beulich wrote:
>>>> On 16.03.17 at 14:09, <andrew.cooper3@xxxxxxxxxx> wrote:
>> On 16/03/17 13:05, Jan Beulich wrote:
>>> Stop creating an excessively large array on the stack, by properly
>>> taking into account the array element size when establishing its
>>> element count (and of course also when calculating the pointer to
>>> be actually used to access the memory).
>> What in practice does this do?  It looks like it reduces the size of the
>> array by 4 or 8 times?
> Correct - it was this much oversized, bloating the stack frame of the
> function quite a bit.

Ok, although it would be helpful if this was called out more clearly in
the commit message.

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel