Re: [Xen-devel] [PATCH RFC 3/5] x86: split PV dom0 builder to domain_build_pv.c

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Fri, Mar 03, 2017 at 09:41:09AM +0000, Wei Liu wrote:
> Long term we want to be able to disentangle PV and HVM code. Move the PV
> domain builder to a dedicated file.
> 
> This in turn requires exposing a few functions and variables via
> a new header domain_build.h.

I would add: "No functional change introduced", to make it clearer that it's
mostly just code movement.

> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
>  xen/arch/x86/Makefile          |   1 +
>  xen/arch/x86/domain_build.c    | 894 +---------------------------------------
>  xen/arch/x86/domain_build.h    |  32 ++

IMHO I would place this in include/asm-x86/, there are really no headers in
arch/x86/.

> diff --git a/xen/arch/x86/domain_build_pv.c b/xen/arch/x86/domain_build_pv.c

I would place this in arch/xen/x86/pv/domain_build.c

> new file mode 100644
> index 0000000000..b4877c8dac
> --- /dev/null
> +++ b/xen/arch/x86/domain_build_pv.c
> @@ -0,0 +1,909 @@
> +/******************************************************************************
> + * domain_build_pv.c
> + */

You should probably keep Kier's copyright here, since this is all PV code.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel