Re: [Xen-devel] [PATCH RFC 0/5] Refactor x86 domain builder

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 03/03/17 09:41, Wei Liu wrote:
> Long term we want to separate different sets of guest supporting code. We 
> would
> like to have CONFIG_HVM and CONFIG_PV (maybe even CONFIG_PVH?).

Probably not PVH.  The only differences between HVM and PVH from Xen's
point of view are some of the emulation choices.

> I will start
> to dientangle Xen code component by component. This is also somewhat related 
> to
> the project to move PV interface inside a PVH container, which I plan to work
> on soon.
>
> RFC because I would like to know whether I should start putting them into pv
> and hvm directory respectively. And I would also like to know the reception of
> the idea to disentangle Xen guest supporting code in general.

+10, although I have a couple of further suggestions.

If we are going to start this, I think we should actually include
CONFIG_{PV,HVM} so we can make the files compilation-safe as they are
touched.

Jan: Would you be happy accepting my CONFIG_{PV,HVM} patch in its silent
form for now?  If so, I will respin it.


I'd also like to us taking the effort to move as much as is suitable
into the pv/ and hvm/ subdirectories, to logically separate it from the
properly common code.

However, with the hypercall series, I was also taking the effort to
ensure that the code (particularly in pv/) was properly bool/const/mfn_t
and style correct, to try and break the cycle of uncertainty and poor
code quality.  For this, I was vaguely planning to clean the code up,
then move the file, rather than the other way around.

> This series is built on top of Roger's PVHv1 removal series.
>
> Wei Liu (5):
>   xen: move round_pg{up,down} to pfn.h
>   xen: include xen/types.h in domain.h
>   x86: split PV dom0 builder to domain_build_pv.c
>   x86: split PVH dom0 builder to domain_build_pv.c
>   x86: clean up header files in domain_build.c

I'd argue that these should be named differently.  They are specifically
hwdom_build.c, distinct from general domain building operations.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel