[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 20/29] xl: split out cd related code



On Mon, Feb 27, 2017 at 04:36:16PM +0000, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH 20/29] xl: split out cd related code"):
> > On Mon, Feb 27, 2017 at 03:56:21PM +0000, Ian Jackson wrote:
> > > Wei Liu writes ("[PATCH 20/29] xl: split out cd related code"):
> > > > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > > > ---
> > > >  tools/xl/Makefile     |   2 +-
> > > >  tools/xl/xl_cd.c      | 114 
> > > > ++++++++++++++++++++++++++++++++++++++++++++++++++
> > > 
> > > Would you mind calling this `libxl_cdrom.c' rather than `_cd' ?
> > > The latter makes me think of chdir...
> > 
> > Can I have your ack if I rename it to libxl_cdrom.c?
> 
> Yes, indeed, that was the only reason I didn't ack it.

Thanks.  I want to avoid reposting as much as possible because this
series is really long and tedious.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.