Re: [Xen-devel] [PATCH 0/2] tools: split xl into a separate directory

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Feb 23, 2017 at 01:20:25PM +0000, Wei Liu wrote:
> On Thu, Feb 23, 2017 at 12:17:38PM +0000, Ian Jackson wrote:
> > Wei Liu writes ("[PATCH 0/2] tools: split xl into a separate directory"):
> > > Xl has grown sufficiently large to warrnant its own directory. We also 
> > > need
> > > clear separation between the client (xl) and library (libxl).
> > 
> > This is a fine idea.
> > 
> > Both patches,
> > 
> > Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > 
> 
> Hmm... It turns out the build system needs a bit more attention.
> Parallel build failed. I will rework and resend.
> 

So libxl needs to be built before xl. 

Basically this needs to be folded into xl/Makefile:

+# libxenlight should be built before building xl
+.PHONY: libxl
+libxl:
+       $(MAKE) -C $(XEN_ROOT)/tools/libxl
+$(XL_OBJS): libxl
+

This is in line with how we do things: libxl/Makefile has something
similar to build libacpi.

Please let me know if you have objection to this.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel