Re: [Xen-devel] [PATCH] x86/MCE: sanitize domain/vcpu ID handling

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 23.02.17 at 13:02, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 23/02/17 09:28, Jan Beulich wrote:
>> --- a/xen/arch/x86/cpu/mcheck/mcaction.c
>> +++ b/xen/arch/x86/cpu/mcheck/mcaction.c
>> @@ -100,7 +100,8 @@ mc_memerr_dhandler(struct mca_binfo *bin
>>                      goto vmce_failed;
>>                  }
>>  
>> -                if ( boot_cpu_data.x86_vendor == X86_VENDOR_INTEL )
>> +                if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL ||
>> +                    global->mc_vcpuid == XEN_MC_VCPUID_INVALID)
> 
> Isn't this a backwards step, style-wise?  This file, using 4 spaces, is
> Xen style rather than Linux style.

The majority of the file is using Linux style _except_ for
indentation. There are, oddly enough, a few exceptions in the
big if() statement towards the end of the file (where this
change also applies to).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel