Re: [Xen-devel] [RFC PATCH v1 03/21] NUMA: Move arch specific NUMA code as common

[Julien Grall <julien.grall@xxxxxxx>]

Hello Vijay,

On 22/02/17 10:08, Vijay Kilari wrote:
> On Mon, Feb 20, 2017 at 6:17 PM, Julien Grall <julien.grall@xxxxxxx> wrote:
> > On 09/02/17 15:56, vijay.kilari@xxxxxxxxx wrote:
> > > diff --git a/xen/common/numa.c b/xen/common/numa.c
> > > index 59dcb63..13f147c 100644
> > > --- a/xen/common/numa.c
> > > +++ b/xen/common/numa.c
> > > @@ -46,6 +46,61 @@ nodeid_t cpu_to_node[NR_CPUS] __read_mostly = {
> > >
> > >  cpumask_t node_to_cpumask[MAX_NUMNODES] __read_mostly;
> > >
> > > +int num_node_memblks;
> > > +struct node node_memblk_range[NR_NODE_MEMBLKS];
> > > +nodeid_t memblk_nodeid[NR_NODE_MEMBLKS];
> > > +struct node nodes[MAX_NUMNODES] __initdata;
> > > +
> > > +int valid_numa_range(u64 start, u64 end, nodeid_t node)
> >
> > I am not sure why you move this code in common code when it is not even used
> > in your series.
> Yes, it is used only by x86 but code is generic. I will keep in x86 to
> void further
> comments on this function.
I was only asking why you move the code and not saying it should not be 
moved...
Anyway, I am ok with the move. But a bit more description in the commit 
message would have been appreciated.
Cheers,

Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel