Re: [Xen-devel] [PATCH v3] ring.h: introduce macros to handle monodirectional rings with multiple req sizes

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.02.17 at 08:47, <andr2000@xxxxxxxxx> wrote:
> On 02/22/2017 09:40 AM, Jan Beulich wrote:
>>>>> On 22.02.17 at 08:16, <andr2000@xxxxxxxxx> wrote:
>>> 3. C89 - Jan, we discussed that a bit for zero-sized arrays [2]
>>> and empty structures [3]. So, then we came to a conclusion that
>>> breakage is not acceptable, but now I see that you have changed
>>> your mind? (Please correct me if I got it wrong). The reason I am
>>> bringing this back to life is that sndif and displif protocols
>>> use grefs[1] construct, while originally I was about to avoid that "1".
>>> So, as now Stefano introduces *grant_ref_t ref[];* I would also
>>> like to change sndif/displif to use the same. Do you think it can be
>>> done this time?
>> I don't think so, no. Please pay close attention to the reason why I
>> think an exception is fine in the case here, but not there: Someone
>> including ring.h without actively using the new macro will not see a
>> compile failure. Someone including sndif.h, otoh, would afaict.
> fair enough, but it means that those who want to use
> PV calls/9pfs will not be able to do so with C89, right?

They would need to customize the header to do so, or introduce a
variant of the macro Stefano proposes elsewhere.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel