Re: [Xen-devel] [PATCH V3 1/7] COLO-Proxy: Add remus command to open userspace proxy

[Zhang Chen <zhangchen.fnst@xxxxxxxxxxxxxx>]

On 02/20/2017 11:50 PM, Wei Liu wrote:
> On Fri, Feb 17, 2017 at 10:18:23AM +0800, Zhang Chen wrote:
> > Add remus '-p' to enable userspace colo proxy(in qemu).
> >
> > Signed-off-by: Zhang Chen <zhangchen.fnst@xxxxxxxxxxxxxx>
> > ---
> >   docs/man/xl.pod.1.in          |  5 +++++
> >   tools/libxl/libxl.h           |  6 ++++++
> >   tools/libxl/libxl_colo.h      |  5 +++++
> >   tools/libxl/libxl_colo_save.c |  2 ++
> >   tools/libxl/libxl_types.idl   | 17 +++++++++--------
> >   tools/libxl/xl_cmdimpl.c      | 13 ++++++++++++-
> >   tools/libxl/xl_cmdtable.c     |  3 ++-
> >   7 files changed, 41 insertions(+), 10 deletions(-)
> >
> > diff --git a/docs/man/xl.pod.1.in b/docs/man/xl.pod.1.in
> > index 09c1faa..4260777 100644
> > --- a/docs/man/xl.pod.1.in
> > +++ b/docs/man/xl.pod.1.in
> > @@ -553,6 +553,11 @@ Disable disk replication. Requires enabling unsafe mode.
> >   Enable COLO HA. This conflicts with B<-i> and B<-b>, and memory
> >   checkpoint compression must be disabled.
> >   
> > +=item B<-p>
> > +
> > +Use userspace COLO Proxy. This option must be used in conjunction
> > +with B<-c>.
> > +
> >   =back
> >   
> >   =item B<pause> I<domain-id>
> > diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
> > index 3924464..fce7fab 100644
> > --- a/tools/libxl/libxl.h
> > +++ b/tools/libxl/libxl.h
> > @@ -870,6 +870,12 @@ typedef struct libxl__ctx libxl_ctx;
> >    */
> >   #define LIBXL_HAVE_REMUS 1
> >   
> > +/*
> > + * LIBXL_HAVE_COLO_USERSPACE_PROXY
> > + * If this is defined, then libxl supports COLO userspace proxy.
> > + */
> > +#define LIBXL_HAVE_COLO_USERSPACE_PROXY 1
> > +
> Please add this macro in a separate patch. It shall be the last patch of
> this series. That way we don't break bisection for libxl users.
I got your point.

Thanks
Zhang Chen

> Wei.
>
>
> .
--
Thanks
Zhang Chen




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel