Re: [Xen-devel] [PATCH 1/3] fuzz/x86emul: avoid race in link farm rune

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.02.17 at 19:56, <wei.liu2@xxxxxxxxxx> wrote:
> --- a/tools/fuzz/x86_instruction_emulator/Makefile
> +++ b/tools/fuzz/x86_instruction_emulator/Makefile
> @@ -8,12 +8,16 @@ else
>  x86-instruction-emulator-fuzzer-all:
>  endif
>  
> -x86_emulate/x86_emulate.c x86_emulate/x86_emulate.h:
> +x86_emulate:
>       [ -L x86_emulate ] || ln -sf $(XEN_ROOT)/xen/arch/x86/x86_emulate .

In addition to what Andrew has asked for, I would then also appreciate
if you used $@ here and ...

> -asm/x86-vendors.h asm/x86-defns.h asm/msr-index.h:
> +x86_emulate/x86_emulate.c x86_emulate/x86_emulate.h: x86_emulate
> +
> +asm:
>       [ -L asm ] || ln -sf $(XEN_ROOT)/xen/include/asm-x86 asm

... here along the lines of ...

> +asm/x86-vendors.h asm/x86-defns.h asm/msr-index.h: asm
> +
>  x86_emulate.c x86_emulate.h: %:
>       [ -L $* ] || ln -sf $(XEN_ROOT)/tools/tests/x86_emulator/$*

the use of $* here. Looking at this last one makes me notice, btw,
that the second argument to ln is missing? Is it portable to assume
that it'll use . in that case?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel