Re: [Xen-devel] [PATCH 10/28] ARM: GICv3: introduce separate pending_irq structs for LPIs

[Julien Grall <julien.grall@xxxxxxx>]

Hi Stefano,

On 14/02/17 20:39, Stefano Stabellini wrote:
> On Mon, 30 Jan 2017, Andre Przywara wrote:
> > For the same reason that allocating a struct irq_desc for each
> > possible LPI is not an option, having a struct pending_irq for each LPI
> > is also not feasible. However we actually only need those when an
> > interrupt is on a vCPU (or is about to be injected).
> > Maintain a list of those structs that we can use for the lifecycle of
> > a guest LPI. We allocate new entries if necessary, however reuse
> > pre-owned entries whenever possible.
> > I added some locking around this list here, however my gut feeling is
> > that we don't need one because this a per-VCPU structure anyway.
> > If someone could confirm this, I'd be grateful.
> > Teach the existing VGIC functions to find the right pointer when being
> > given a virtual LPI number.
> >
> > Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>
> Please address past comments, specifically use a data structure per
> domain, rather than per-vcpu. Also please move to a more efficient data
> structure, such as an hashtable or a tree.
+1 for both. We need to limit the memory used by a domain.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel