[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 2/2] build/printf: fix incorrect format specifiers



On Mon, Feb 13, 2017 at 07:50:07AM -0700, Jan Beulich wrote:
> >>> On 13.02.17 at 15:34, <roger.pau@xxxxxxxxxx> wrote:
> > --- a/xen/arch/x86/cpu/mcheck/mce.c
> > +++ b/xen/arch/x86/cpu/mcheck/mce.c
> > @@ -595,9 +595,8 @@ int show_mca_info(int inited, struct cpuinfo_x86 *c)
> >              [mcheck_intel] = "Intel"
> >          };
> >  
> > -        snprintf(prefix, ARRAY_SIZE(prefix),
> > -                 g_type != mcheck_unset ? XENLOG_WARNING "CPU%i: "
> > -                 : XENLOG_INFO,
> > +        snprintf(prefix, ARRAY_SIZE(prefix), "%sCPU%i: ",
> > +                 g_type != mcheck_unset ? XENLOG_WARNING : XENLOG_INFO,
> >                   smp_processor_id());
> 
> Should I end up committing this, I'll take the liberty of using %u
> instead of %i here.

Done, I will be sending a new version shortly.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.