Re: [Xen-devel] [PATCH V2] common/vm_event: Prevent guest locking with large max_vcpus

[Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>]

On 02/09/2017 06:39 PM, Tamas K Lengyel wrote:
>> @@ -316,8 +302,9 @@ void vm_event_put_request(struct domain *d,
>>       * See the comments above wake_blocked() for more information
>>       * on how this mechanism works to avoid waiting. */
>>      avail_req = vm_event_ring_available(ved);
>> -    if( current->domain == d && avail_req < d->max_vcpus )
>> -        vm_event_mark_and_pause(current, ved);
>> +    if( curr->domain == d && avail_req < d->max_vcpus /* &&
>> +        !atomic_read(&curr->vm_event_pause_count) */ )
> 
> Seems like you left the atomic_read in a comment block here (I assume
> while testing if the waking code now works as expected).

Yes, sorry about that. I'll send V3 in a few minutes with that omission
fixed.


Thanks,
Razvan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel