Re: [Xen-devel] [RFC XEN PATCH 15/16] tools/libxl: handle return code of libxl__qmp_initializations()

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Feb 08, 2017 at 02:07:26PM +0800, Haozhong Zhang wrote:
> On 01/27/17 17:11 -0500, Konrad Rzeszutek Wilk wrote:
> > On Mon, Oct 10, 2016 at 08:32:34AM +0800, Haozhong Zhang wrote:
> > > If any error code is returned when creating a domain, stop the domain
> > > creation.
> > 
> > This looks like it is a bug-fix that can be spun off from this
> > patchset?
> > 
> 
> Yes, if everyone considers it's really a bug and the fix does not
> cause compatibility problem (e.g. xl w/o this patch does not abort the
> domain creation if it fails to connect to QEMU VNC port).
> 

I'm two minded here. If the failure to connect is caused by some
temporary glitches in QEMU and we're sure it will eventually succeed,
there is no need to abort domain creation. If failure to connect is due
to permanent glitches, we should abort.

OOI how did you discover this issue? That could be the key to understand
the issue here.

Wei.

> Thanks,
> Haozhong
> 
> > > 
> > > Signed-off-by: Haozhong Zhang <haozhong.zhang@xxxxxxxxx>
> > > ---
> > > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > > Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> > > ---
> > >  tools/libxl/libxl_create.c | 4 +++-
> > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
> > > index d986cd2..24e8368 100644
> > > --- a/tools/libxl/libxl_create.c
> > > +++ b/tools/libxl/libxl_create.c
> > > @@ -1499,7 +1499,9 @@ static void domcreate_devmodel_started(libxl__egc 
> > > *egc,
> > >      if (dcs->sdss.dm.guest_domid) {
> > >          if (d_config->b_info.device_model_version
> > >              == LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) {
> > > -            libxl__qmp_initializations(gc, domid, d_config);
> > > +            ret = libxl__qmp_initializations(gc, domid, d_config);
> > > +            if (ret)
> > > +                goto error_out;
> > >          }
> > >      }
> > > 
> > > --
> > > 2.10.1
> > > 
> > > 
> > > _______________________________________________
> > > Xen-devel mailing list
> > > Xen-devel@xxxxxxxxxxxxx
> > > https://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel