Re: [Xen-devel] [PATCH v4 05/12] x86emul/test: use x86-vendors.h

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.02.17 at 12:53, <wei.liu2@xxxxxxxxxx> wrote:
> --- a/tools/fuzz/x86_instruction_emulator/Makefile
> +++ b/tools/fuzz/x86_instruction_emulator/Makefile
> @@ -11,16 +11,20 @@ endif
>  x86_emulate/x86_emulate.c x86_emulate/x86_emulate.h:
>       [ -L x86_emulate ] || ln -sf $(XEN_ROOT)/xen/arch/x86/x86_emulate .
>  
> +asm/x86-vendors.h:
> +     [ -L asm ] || ln -sf $(XEN_ROOT)/xen/include/asm-x86 asm
> +
>  x86_emulate.c x86_emulate.h: %:
>       [ -L $* ] || ln -sf $(XEN_ROOT)/tools/tests/x86_emulator/$*
>  
> -CFLAGS += $(CFLAGS_xeninclude) -D__XEN_TOOLS__
> +CFLAGS += $(CFLAGS_xeninclude) -D__XEN_TOOLS__ -I.
>  
>  x86_emulate.h := x86_emulate.h x86_emulate/x86_emulate.h
> +x86.h := asm/x86-vendors.h
>  
> -x86_emulate.o: x86_emulate.c x86_emulate/x86_emulate.c $(x86_emulate.h)
> +x86_emulate.o: x86_emulate.c x86_emulate/x86_emulate.c $(x86_emulate.h) 
> $(x86.h)
>  
> -x86-insn-emulator-fuzzer.o: $(x86_emulate.h)
> +x86-insn-emulator-fuzzer.o: $(x86_emulate.h) $(x86.h)

It's probably okay as is, but the consistent model would have been
to add to x86_emulate.h, as that's the header which does the
inclusion (and that's what the macro is supposed to represent). Of
course you could collect things in x86.h first and then add $(x86.h)
to x86_emulate.h.

Preferably with that adjustment (but I won't grumble too much if
you don't want to do it)
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel