[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] x86/EFI: fix build when using GNU Make 4.1



Since c/s eee5909e9d (x86/EFI: use less crude a way of generating the
build ID) builds have been broken when using GNU Make 4.1. This is
because there are no dependencies on buildid.o and as such GNU Make does
not build it. This adds a dependency so that it is built.

Note: This patch is different than I was going to originally submit, I
had used runtime.o but while testing this I saw Daniel Kiper's v14 of
his multiboot2 series come along and I modified my patch so that he
would not have to rebase.

Signed-off-by: Doug Goldstein <cardoe@xxxxxxxxxx>
---
CC: Jan Beulich <jbeulich@xxxxxxxx>
CC: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Jan,
  This needs to be backported to 4.8 as well.
---
 xen/arch/x86/efi/Makefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/xen/arch/x86/efi/Makefile b/xen/arch/x86/efi/Makefile
index ad3fdf7..af5324f 100644
--- a/xen/arch/x86/efi/Makefile
+++ b/xen/arch/x86/efi/Makefile
@@ -14,5 +14,7 @@ extra-$(efi) += boot.init.o relocs-dummy.o runtime.o compat.o 
buildid.o
 %.o: %.ihex
        $(OBJCOPY) -I ihex -O binary $< $@
 
+boot.init.o: buildid.o
+
 stub.o: $(extra-y)
 nogcov-$(efi) += stub.o
-- 
2.10.2


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.