Re: [Xen-devel] [PATCH v2 09/12] x86emul: use TRAP definitions in x86-defns.h

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 31/01/17 11:08, Wei Liu wrote:
> And remove duplicates.
>
> No functional change.
>
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
>  xen/arch/x86/x86_emulate/x86_emulate.c | 305 
> +++++++++++++++------------------
>  1 file changed, 142 insertions(+), 163 deletions(-)
>
> diff --git a/xen/arch/x86/x86_emulate/x86_emulate.c 
> b/xen/arch/x86/x86_emulate/x86_emulate.c
> index d09b861622..ac86de7b5f 100644
> --- a/xen/arch/x86/x86_emulate/x86_emulate.c
> +++ b/xen/arch/x86/x86_emulate/x86_emulate.c
> @@ -421,27 +421,6 @@ typedef union {
>  /* MXCSR bit definitions. */
>  #define MXCSR_MM  (1U << 17)
>  
> -/* Exception definitions. */
> -#define EXC_DE  0
> -#define EXC_DB  1
> -#define EXC_BP  3
> -#define EXC_OF  4
> -#define EXC_BR  5
> -#define EXC_UD  6
> -#define EXC_NM  7
> -#define EXC_DF  8
> -#define EXC_TS 10
> -#define EXC_NP 11
> -#define EXC_SS 12
> -#define EXC_GP 13
> -#define EXC_PF 14
> -#define EXC_MF 16
> -#define EXC_AC 17
> -#define EXC_XM 19
> -
> -#define EXC_HAS_EC                                                      \
> -    ((1u << EXC_DF) | (1u << EXC_TS) | (1u << EXC_NP) |                 \
> -     (1u << EXC_SS) | (1u << EXC_GP) | (1u << EXC_PF) | (1u << EXC_AC))

Most of the changes are fine, but this one I was planning to do the
other way round.  X86_EXC_xx is a more concise representation, more
accurately named (i.e. without 'trap') and matches the terminology used
in the Intel and AMD manuals.

IMO it would be fine to have duplicate names in x86-defs.h for a
transition period.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel