Re: [Xen-devel] [PATCH v4 5/8] dm_op: convert HVMOP_modified_memory

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 17/01/17 17:29, Paul Durrant wrote:
> diff --git a/xen/arch/x86/hvm/dm.c b/xen/arch/x86/hvm/dm.c
> index 12a82e5..dd81116 100644
> --- a/xen/arch/x86/hvm/dm.c
> +++ b/xen/arch/x86/hvm/dm.c
> @@ -14,6 +14,7 @@
>   * this program; If not, see <http://www.gnu.org/licenses/>.
>   */
>  
> +#include <xen/event.h>
>  #include <xen/guest_access.h>
>  #include <xen/hypercall.h>
>  #include <xen/sched.h>
> @@ -105,6 +106,59 @@ static int set_isa_irq_level(struct domain *d, uint8_t 
> isa_irq,
>      return 0;
>  }
>  
> +static int modified_memory(struct domain *d, xen_pfn_t *first_pfn,
> +                           unsigned int *nr)

The logic below would be clearer if you passed data by pointer, rather
that each subfield by pointer.

Either way, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel