[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 4/6] tools: expand export.h with VMLINUX_SYMBOL()



On Sun, Jan 15, 2017 at 01:12:13PM -0800, Luis R. Rodriguez wrote:
> This will be used later by the linker-table userspace sandbox.
> 
> Signed-off-by: Luis R. Rodriguez <mcgrof@xxxxxxxxxx>
> ---
>  tools/include/linux/export.h | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/tools/include/linux/export.h b/tools/include/linux/export.h
> index d07e586b9ba0..cb7d6b490e08 100644
> --- a/tools/include/linux/export.h
> +++ b/tools/include/linux/export.h
> @@ -1,6 +1,28 @@
>  #ifndef _TOOLS_LINUX_EXPORT_H_
>  #define _TOOLS_LINUX_EXPORT_H_
>  
> +/*
> + * Export symbols from the kernel to modules.  Forked from module.h
> + * to reduce the amount of pointless cruft we feed to gcc when only
> + * exporting a simple symbol or two.

You copied it, yet did not remove it from the original?

> + *
> + * Try not to add #includes here.  It slows compilation and makes kernel
> + * hackers place grumpy comments in header files.

Define "slows" please.  I doubt it is measurable, and so, why even
mention it here?

thanks,

greg k-h

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.