Re: [Xen-devel] [PATCH] tools/tests: add xenstore testing framework

[Juergen Gross <jgross@xxxxxxxx>]

On 18/01/17 18:59, David Scott wrote:
> 
>> On 18 Jan 2017, at 15:23, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
>>
>> On Wed, Jan 18, 2017 at 04:16:22PM +0100, Juergen Gross wrote:
>>> On 18/01/17 13:33, Juergen Gross wrote:
>>>> Add tools/tests/xenstore for a framework to do tests of xenstore.
>>>> The aim is to test for correctness and performance.
> 
> This is a great idea!

When you are doing critical changes to xenstore this is kind of
mandatory. ;-)

>>>>
>>>> Add a test program containing some tests meant to be run against any
>>>> xenstore implementation (xenstored, oxenstored, xenstore-stubdom).
>>>>
>>>> It is using libxenstore for access to xenstore and supports multiple
>>>> tests to be either selected all or individually. All tests are using
>>>> /local/domain/<own-domid>/xenstore-test/<pid> as base for doing the
>>>> tests. This allows multiple instances of the program to run in
>>>> parallel.
>>>>
>>>> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>>>
>>> BTW: when running the tests against oxenstored I discovered that
>>> oxenstored is applying the default Xenstore entry size limit of 2000
>>> bytes for dom0, too. All other limits are effective for domUs only.
>>> Is this on purpose?
>>>
>>
>> I don't know.
>>
>> CC our oxenstored maintainer for input.
> 
> I don’t think it’s on purpose— I suspect the code evolved a bit, and dom0 was 
> exempted from one quota but not another.
> 
> I think it makes sense to be consistent and to enforce the quotas for domUs 
> only.

Nice. First bug found by the test program. :-)


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel