Re: [Xen-devel] [PATCH] xen/common: Drop function calls for Xen compile/version information

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.01.17 at 14:04, <andrew.cooper3@xxxxxxxxxx> wrote:
> The chageset/version/compile information is currently exported as a set of
> function calls into a separate translation unit, which is inefficient for all
> callers.
> 
> Replace the function calls with externs pointing appropriately into .rodata,
> which allows all users to generate code referencing the data directly.
> 
> No functional change, but causes smaller and more efficient compiled code.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Provided especially the "smaller" part above really hold at least
on average over the entire change (which I'm not convinced it
does),
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel