[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v3 4/8] x86: stop exporting msr-index.h to userland
- To: Nicolas Dichtel <nicolas.dichtel@xxxxxxxxx>
- From: Borislav Petkov <bp@xxxxxxxxx>
- Date: Fri, 13 Jan 2017 17:38:36 +0100
- Cc: linux-mips@xxxxxxxxxxxxxx, linux-m68k@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, alsa-devel@xxxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, David Howells <dhowells@xxxxxxxxxx>, linux-mtd@xxxxxxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-am33-list@xxxxxxxxxx, linux-c6x-dev@xxxxxxxxxxxxx, linux-rdma@xxxxxxxxxxxxxxx, linux-hexagon@xxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, linux@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx, fcoe-devel@xxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-snps-arc@xxxxxxxxxxxxxxxxxxx, linux-media@xxxxxxxxxxxxxxx, uclinux-h8-devel@xxxxxxxxxxxxxxxxxxxx, linux-xtensa@xxxxxxxxxxxxxxxx, arnd@xxxxxxxx, linux-kbuild@xxxxxxxxxxxxxxx, adi-buildroot-devel@xxxxxxxxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, openrisc@xxxxxxxxxxxxxxxxxxxx, linux-fbdev@xxxxxxxxxxxxxxx, linux-metag@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, linux-parisc@xxxxxxxxxxxxxxx, linux-cris-kernel@xxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-mmc@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-spi@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, linux-alpha@xxxxxxxxxxxxxxx, nios2-dev@xxxxxxxxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx
- Delivery-date: Fri, 13 Jan 2017 16:38:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On Fri, Jan 13, 2017 at 05:08:34PM +0100, Nicolas Dichtel wrote:
> Le 13/01/2017 à 16:43, David Howells a écrit :
> >> -header-y += msr-index.h
> >
> > I see it on my desktop as /usr/include/asm/msr-index.h and it's been there
> > at
> > least four years - and as such it's part of the UAPI. I don't think you can
> > remove it unless you can guarantee there are no userspace users.
> I keep it in the v2 of the series, but the maintainer, Borislav Petkov, asks
> me
> to un-export it.
>
> I will follow the maintainer decision.
I'm not the maintainer. I simply think that exporting that file was
wrong because it if we change something in it, we will break userspace.
And that should not happen - if userspace needs MSRs, it should do its
own defines.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel
|
