Re: [Xen-devel] [PATCH v3 3/8] dm_op: convert HVMOP_track_dirty_vram

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: 13 January 2017 11:45
> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
> Cc: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>; George Dunlap
> <George.Dunlap@xxxxxxxxxx>; Ian Jackson <Ian.Jackson@xxxxxxxxxx>; xen-
> devel@xxxxxxxxxxxxxxxxxxxx; Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>; Tim
> (Xen.org) <tim@xxxxxxx>
> Subject: Re: [PATCH v3 3/8] dm_op: convert HVMOP_track_dirty_vram
> 
> >>> On 12.01.17 at 15:58, <paul.durrant@xxxxxxxxxx> wrote:
> > v3:
> > - Check d->max_vcpus rather than d->vcpu, as requested by Jan.
> > - The handle type changes (from uint8 to void) are still necessary, hence
> >   omitting Jan's R-b until this is confirmed to be acceptable.
> 
> Hmm, talk really was of the change from HANDLE_64() to
> HANDLE_PARAM(), which I see you also left as they were. In the end,
> if this builds I'm fine either way, and since you say you need to do
> the uint8 -> void change anyway, doing the 64 -> PARAM change at
> once is perhaps even a change to the better. So hypervisor parts
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> 

Ok. Thanks,

  Paul

> Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel