[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 06/24] x86: refactor psr: implement get hw info flow.



>>> On 11.01.17 at 06:13, <yi.y.sun@xxxxxxxxxxxxxxx> wrote:
> On 17-01-10 06:46:03, Jan Beulich wrote:
>> >>> On 14.12.16 at 05:07, <yi.y.sun@xxxxxxxxxxxxxxx> wrote:
>> > +int psr_get_info(unsigned int socket, enum cbm_type type,
>> > +                 uint32_t dat[], uint32_t array_len)
>> > +{
>> > +    struct psr_socket_info *info = get_socket_info(socket);
>> > +    struct feat_node *feat_tmp;
>> 
>> With the hook function taking a pointer to const I don#t see why
>> this one can't be const, too.
>> 
> Do you mean feat_tmp? Thanks!

Not sure why you ask - yes, that's why I've placed the comment at
precisely this line.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.