Re: [Xen-devel] [PATCH v4 2/6] x86emul: correct EFLAGS.TF handling

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 10/01/17 09:03, Jan Beulich wrote:
> For repeated string instructions we should not emulate multiple
> iterations in one go when a single step trap needs injecting (which
> needs to happen after every iteration).
>
> For all non-branch instructions as well as not taken conditional
> branches we additionally need to take DebugCtl.BTF into consideration.
>
> For mov-to/pop-into %ss there should be no #DB at all (EFLAGS.TF
> remaining set means there'll be #DB after the next instruction).
>
> And retire.sti should remain clear when retire.singlestep gets set to
> true.

Starting a sentence with "And" is considered poor grammar.  "Finally"
would be ok (which is perhaps what you mean?), or simply omitting it and
starting with "retire" would be fine.

>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel